Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlr3 targets post #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

mlr3 targets post #41

wants to merge 3 commits into from

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented May 9, 2022

An image would be nice but the output from tar_visNetwork() is too large and the nodes become too small.

Thoughts? Feedback?

@pat-s pat-s requested review from be-marc, mllg and sebffischer May 9, 2022 16:04
Copy link
Sponsor Member

@sebffischer sebffischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know targets so can only really comment once I am familiar

knitr::opts_chunk$set(echo = FALSE)
```

The [mlr3-learndrake](https://github.com/mlr-org/mlr3-learndrake) repository has been deprecated and (finally) been ported to it's successor {targets}.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's -> its

• built branch bm_be2cba98
✔ skip branch bm_da5f38fa
• built pattern bm
```
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add one of these figures with red and green targets instead of the log.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tried but I couldn't get them large enough to be well visible in the post. Usually one does it with zooming but this is ofc not an option here.

@pat-s
Copy link
Member Author

pat-s commented May 18, 2022

Blocked by #43

@sebffischer
Copy link
Sponsor Member

If we merge to quarto, we could use a mermaid diagram for the visualization

@pat-s pat-s force-pushed the main branch 12 times, most recently from dcc2a4a to 166c415 Compare October 30, 2022 09:43
@pat-s pat-s force-pushed the main branch 7 times, most recently from f10f1ca to 2b02238 Compare November 3, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants